fix(cli): show not-enabled guidance on 404 for project create#3096
Draft
jorgemoya wants to merge 1 commit into
Draft
fix(cli): show not-enabled guidance on 404 for project create#3096jorgemoya wants to merge 1 commit into
jorgemoya wants to merge 1 commit into
Conversation
The Infrastructure Projects API returns 404 (not just 403) when the beta feature flag is off for a store, which previously fell through to a cryptic "Not Found" error. Treat 404 the same as 403 and surface the actionable "contact support to join the beta" guidance via UserActionableError. Refs LTRAC-1089 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 40b5b28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Bundle Size ReportComparing against baseline from No bundle size changes detected. |
Contributor
Unlighthouse Performance Comparison — VercelComparing PR preview deployment Unlighthouse scores vs production Unlighthouse scores. Summary ScoreAggregate score across all categories as reported by Unlighthouse.
Category Scores
Core Web Vitals
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: LTRAC-1089
What/Why?
createProjectmapped403to a friendly "Infrastructure Projects API not enabled — contact support to join the beta" message, but a404(what the API appears to return when the flag is off) fell through to a crypticFailed to create project: Not Found. This treats404the same as403, surfacing the actionable guidance viaUserActionableError.Open question: the exact status the API returns when the flag is disabled should be confirmed with the API team — this handles both
403and404to be safe.Testing
project.spec.tscovers the not-enabled path (44 tests pass).typecheckandlintpass.Migration
None.