Repository navigation
Conversation
|
You have reached your Codex usage limits for security reviews. Please try again later. |
Runs cargo check + lib tests on the tempsdev1 self-hosted runner for pushes to main/feature/**/fix/** and manual dispatch. Scoped to push and workflow_dispatch only (never pull_request/pull_request_target) so fork PRs can never execute on the self-hosted host. Uses a persistent, isolated CARGO_TARGET_DIR outside the runner work dir so the build cache survives checkout cleans and is reused across runs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
A warm CARGO_TARGET_DIR caches the example plugins' build-script fingerprint,
so after actions/checkout git-cleans the source tree the script is skipped and
include_dir!(".../web/dist") panics on the missing dir. Recreate the debug
placeholder assets up front so the check is independent of build-script cache.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
temps-cli embeds crates/temps-cli/dist via include_dir!; like the example plugins its build.rs placeholder is skipped on a warm cache, so generalize the prep step to cover every include_dir! dist target, not just the plugins. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…vy crates cargo test --lib --workspace pulled in temps-domains' real-Pebble ACME tests, which need a challenge-responder network this box can't provide. Match the unit-a/unit-b crate list from rust-tests.yml instead (Docker+networking-heavy crates run in hosted's dedicated integration jobs, not here). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Its local_provider tests launch a real bundled Chromium against live example.com/github.com. The hosted ubuntu-latest image ships google-chrome system-wide so headless_chrome reuses it; this self-hosted box has no system browser, so headless_chrome auto-downloads one and the parallel tests race on the binary (Text file busy) and debug ports (no available ports between 8000 and 9000). It is a live-network browser integration test, not a unit test, and hosted CI already covers it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
bherila
force-pushed
the
codex/propose-fix-for-webhook-ssrf-vulnerability
branch
from
August 15, 2026 07:43
9fe41ed to
8d70ce8
Compare
📓 Changelog previewThis is what your commits will add to the generated ## [Unreleased]
### CI
- **self-hosted:** Add build/test workflow on push to bherila fork
- **self-hosted:** Recreate example-plugin web/dist before cargo check
- **self-hosted:** Also recreate temps-cli/dist placeholder
- **self-hosted:** Run hosted unit-test crate set, skip integration-heavy crates
- **self-hosted:** Exclude temps-screenshots live-browser tests
### Fixed
- **notifications:** Harden webhook SSRF validation |
Owner
Author
|
The functional change was carried into upstream security-hardening PR gotempsh#676 and its merged replacement gotempsh#677. Upstream gotempsh#676 explicitly lists this fork PR in its source coverage. Fork main has now been fast-forwarded to upstream main at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
http(s)://targets and performed server-side requests without the repository's URL/SSRF defenses or redirect restrictions.Description
temps-corevalidators by runningvalidate_external_urlandvalidate_domain_asyncfor create/update API requests and before provider execution.validate_webhook_urlhelper and awebhook_http_clientthat setsreqwest::redirect::Policy::none()to prevent redirect-based SSRF during delivery and health checks.initialize,send, andhealth_checkpaths so execution-time targets are checked as well as API inputs.CHANGELOG.mdwith a security note.crates/temps-notifications/src/services.rs,crates/temps-notifications/src/handlers.rs, andCHANGELOG.md.Testing
cargo fmt --checkwhich passed.cargo check -p temps-notifications --libwhich completed successfully.cargo test -p temps-notifications webhook_ssrf --libandcargo test -p temps-notifications test_webhook_url_validation --lib, and both test sets passed (all tests green).Codex Task