Skip to content

fix(proxy): scope CAS static asset lookup - #71

Closed
bherila wants to merge 6 commits into
mainfrom
codex/fix-cas-static-asset-serving-vulnerability
Closed

bherila wants to merge 6 commits into
mainfrom
codex/fix-cas-static-asset-serving-vulnerability

Conversation

@bherila

@bherila bherila commented Aug 15, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Address a security regression where the proxy could serve CAS-cached static assets scoped only by project_id and url_path, allowing assets from different environments or deployments in the same project to be served on the current host.
  • Prevent prefixed URLs like /_temps/assets/{deployment_slug}/... from discarding the slug and serving a colliding path from another deployment.
  • Ensure the change is recorded in the repository CHANGELOG.md per project conventions.

Description

  • Restrict CAS DB lookups in serve_asset_from_store to require the routed project_id, environment_id, and deployment_id instead of selecting the newest same-project row by deployment_id (change in crates/temps-proxy/src/proxy.rs).
  • Validate /_temps/assets/{deployment_slug}/... requests against the currently routed deployment slug before using the path for a CAS lookup (change in crates/temps-proxy/src/proxy.rs).
  • Add helper methods to ProxyContext: static_asset_scope_ids and matches_current_deployment_slug to encapsulate scoping and slug checks (added to crates/temps-proxy/src/proxy.rs).
  • Add an Unreleased CHANGELOG.md entry describing the scoped CAS static-asset fallback security fix.

Testing

  • Ran cargo check -p temps-proxy --lib, which completed successfully with no warnings-as-errors blocking compilation.
  • Ran cargo test -p temps-proxy --lib; the test run completed build and executed unit tests with 305 tests passing, but 26 tests failed and 6 were ignored because this environment lacks a Docker socket at /var/run/docker.sock (the failures are Docker-dependent tests), so the failures are environmental rather than caused by the logic change.
  • Verified git diff --check and updated CHANGELOG.md as required by repository conventions.

Codex Task

bherila and others added 6 commits August 15, 2026 07:44
Runs cargo check + lib tests on the tempsdev1 self-hosted runner for
pushes to main/feature/**/fix/** and manual dispatch. Scoped to push
and workflow_dispatch only (never pull_request/pull_request_target) so
fork PRs can never execute on the self-hosted host. Uses a persistent,
isolated CARGO_TARGET_DIR outside the runner work dir so the build
cache survives checkout cleans and is reused across runs.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
A warm CARGO_TARGET_DIR caches the example plugins' build-script fingerprint,
so after actions/checkout git-cleans the source tree the script is skipped and
include_dir!(".../web/dist") panics on the missing dir. Recreate the debug
placeholder assets up front so the check is independent of build-script cache.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
temps-cli embeds crates/temps-cli/dist via include_dir!; like the example
plugins its build.rs placeholder is skipped on a warm cache, so generalize the
prep step to cover every include_dir! dist target, not just the plugins.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…vy crates

cargo test --lib --workspace pulled in temps-domains' real-Pebble ACME tests,
which need a challenge-responder network this box can't provide. Match the
unit-a/unit-b crate list from rust-tests.yml instead (Docker+networking-heavy
crates run in hosted's dedicated integration jobs, not here).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Its local_provider tests launch a real bundled Chromium against live
example.com/github.com. The hosted ubuntu-latest image ships
google-chrome system-wide so headless_chrome reuses it; this self-hosted
box has no system browser, so headless_chrome auto-downloads one and the
parallel tests race on the binary (Text file busy) and debug ports (no
available ports between 8000 and 9000). It is a live-network browser
integration test, not a unit test, and hosted CI already covers it.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@bherila
bherila force-pushed the codex/fix-cas-static-asset-serving-vulnerability branch from 8a72f3c to 0dc8af0 Compare August 15, 2026 07:44
@github-actions

Copy link
Copy Markdown

📓 Changelog preview

This is what your commits will add to the generated CHANGELOG.md at release time (via git-cliff). Do not edit CHANGELOG.md by hand — it is generated from your Conventional Commit messages.

## [Unreleased]

### CI

- **self-hosted:** Add build/test workflow on push to bherila fork
- **self-hosted:** Recreate example-plugin web/dist before cargo check
- **self-hosted:** Also recreate temps-cli/dist placeholder
- **self-hosted:** Run hosted unit-test crate set, skip integration-heavy crates
- **self-hosted:** Exclude temps-screenshots live-browser tests

### Fixed

- **proxy:** Scope CAS static asset lookup

@bherila

bherila commented Oct 11, 2026

Copy link
Copy Markdown
Owner Author

The functional change was carried into upstream security-hardening PR gotempsh#676 and its merged replacement gotempsh#677. Upstream gotempsh#676 explicitly lists this fork PR in its source coverage.

Fork main has now been fast-forwarded to upstream main at 7250ab59b38d3138014ade7f5d6391c856eaa4f7. Closing this obsolete fork PR as part of the upstream synchronization; its branch history is retained.

@bherila bherila closed this Oct 11, 2026
@bherila
bherila deleted the codex/fix-cas-static-asset-serving-vulnerability branch October 11, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant