Repository navigation
drift/06b: parity tooling fixes from the integrated review - #27
Merged
Merged
Conversation
…tant pairs, lexer edges, CI toolchain path (#17) Fixes the six confirmed findings from the integrated drift/meta review: ratchet validates the differential registry per sharp module pair (second sharp pair no longer fails), counts each registered name once; the CI coverage job derives llvm-cov from the swift toolchain on PATH and treats Tools/parity_*.json as twin-touching; --write-baseline merges by identity so hand-added issue fields survive; unresolvable constant_pairs raise stale-constant-pair instead of silently dropping the value gate; the lexer accepts wrapped multiline signatures and no longer inventories explicit Kotlin primary constructors as body constructors; CLAUDE.md reflects the proven StrandAnalytics Linux path (docs/LINUX.md). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013r1YRhfH9HfZ6ES9uSwYvp
9 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the six confirmed tooling findings from the independent review of the integrated
drift/metastate, plus three findings from this branch's own review round:second pair no longer fails; each registered name counts once; coverage is proven
for every pair that resolves a name.
llvm-covis derived from the resolved (readlink -f) Swifttoolchain with a fail-fast check, replacing a hardcoded local path;
Tools/parity_*.jsonnow counts as twin-touching for the coverage job.--write-baselinemerges by identity so hand-addedissuefieldssurvive regeneration; unresolvable
constant_pairsraisestale-constant-pairinstead of silently dropping the value gate.
-> Type {,where … {) are recognized;a bodyless declaration no longer captures the following declaration's brace;
explicit Kotlin primary constructors are no longer inventoried as body constructors.
docs/LINUX.md).Verification:
Tools/tests70/70 green; ledger exit 0 (274 baselined, 0 new);ratchet/verifyexit 0 against real llvm-cov + JaCoCo artifacts; no/opt/pathsremain in the workflow. No Swift/Kotlin production sources touched.
Part of #17.