Skip to content

P2: Smaller review findings from the 10.1.0-10.1.1 upstream range (collective) #32

Open

Description

@bhelm

Collective issue for the smaller findings from the independent review of the integrated fork
state (2026-08-18). All arrived with the upstream range d4b7cc8..f2271cd. Each was verified,
but with less depth than the individually filed ones — worth a check before fixing. Filed here
first; forwarding upstream is a separate decision.

  • BreathProtocol.kt throws where Swift clamps — the Kotlin protocol player raises on
    out-of-range input that the Swift twin clamps; a malformed catalog entry would crash Android
    and degrade gracefully on Apple platforms.
  • hrOnlyFallback misreports under its compile-time gate — the reported fallback state
    does not match actual behavior when the compile-time flag disables the path.
  • marginToSigma guard fails at band ≤ 1.5 — the guard band arithmetic breaks down for
    narrow bands.
  • StressView / StressScreen re-read 30 days of raw streams on every refresh — no
    caching layer between the screens and the stores; noticeable battery/latency cost on the
    stress screens.
  • BreatheScreen uses a 50 ms polling loop — Android breathe animation polls instead of
    deriving state from frame time.

If any of these graduates into real work, it should get its own issue with anchors and a
failure scenario.

Activity

  1. changed the title [-]Smaller review findings from the 10.1.0-10.1.1 upstream range (collective)[/-] [+]P2: Smaller review findings from the 10.1.0-10.1.1 upstream range (collective)[/+] on Aug 18, 2026
  2. bhelm commented on Aug 18, 2026

    @bhelm
    OwnerAuthor

    Partial upstream follow-up

    ryanbr/noop#1436 addresses the first finding only: Kotlin now clamps negative breath-stage durations to zero, matching Swift.

    Mirrored Swift and Kotlin tests cover construction, cycle duration, and scheduling behavior. GitHub currently reports the PR as cleanly mergeable, with all reported checks passing.

    The other findings collected in this issue are unaffected, so this issue remains open regardless of the outcome of that PR.

  3. bhelm commented on Aug 19, 2026

    @bhelm
    OwnerAuthor

    Upstream update: ryanbr#1436 merged as 117f769, completing the negative BreathStage-duration item. The other four findings in this collective issue remain unresolved, so the issue stays open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions