Fix issue with negative predictions; treat nil COB as zero. #6
Closed
elnjensen wants to merge 2 commits intobharat:dev-watch-skfrom
Closed
Fix issue with negative predictions; treat nil COB as zero. #6elnjensen wants to merge 2 commits intobharat:dev-watch-skfrom
elnjensen wants to merge 2 commits intobharat:dev-watch-skfrom
Conversation
Author
|
Closing - fixed on the other end. |
bharat
pushed a commit
that referenced
this pull request
May 6, 2019
* Bolus progress and quick cancellation * Add MKRingProgressView files directly * Update LICENCE file to include license for MKRingProgressView * Use MKRingProgressView via carthage * Use pumpmanager's bolusProgressEstimator * Updates from code review: - Delay removal of bolus progress so user sees progress finish - Reset ring progress during cell re-use - Tweak cornerRadius - Code clarity updates * PumpManager Protocol updates * Protocol naming update * Create bolus progress reporter * Fix progress animating from 1 to 0 on reuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the negative prediction crash - if you prefer to leave out the COB commit, that's fine.