Repository navigation
fix(desktop): wrap the fetch status so the left pane keeps its width - #217
Merged
Merged
Conversation
The status beside the fetch spinner sat in an unwrapped row, so a long status widened the resizable inputs panel, which then kept that width. It now wraps in what the spinner leaves. A headless kittest guards it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
While a tenant fetch (Fetch & analyze or Forecast only) runs, the inputs panel shows a spinner plus the current status. That row was an unwrapped
ui.horizontal, so a long status (e.g. the sign-in line with its tenant id) widened the resizable left panel, and egui kept that width for the rest of the session.The status now sits in a
horizontal_toprow with a wrapping label, so it wraps inside the panel instead.Tests
fetch_status_keeps_the_inputs_panel_widthrenders the tenant form with a long status and asserts it stays inside the 320px panel. Without the fix it fails (status reaches x ≈ 754); with it, it passes.cargo fmt --check,cargo clippy --all-targetsandcargo testindesktop-egui/are clean.Notes for reviewers
[Unreleased]→ Fixed.