This repository was archived by the owner on Apr 19, 2025. It is now read-only.
Reorder bind and on: for select (fixes #461)#468
Closed
clemens-tolboom wants to merge 1 commit into
Closed
Conversation
This should fix bestguy#461.
|
This will fix the issue for
I'd apply the fix at every point possible in the file (bare in mind there are sub-components referenced in Maybe add a test too? Oh, I forgot to mention, I've already fixed this on another fork (with tests). I never created a PR though as some of the original tests were failing, the failures seemed unrelated to my changes, however. I can create a PR and save you the work if you like? |
Author
|
@shaun-wild a PR would be great ... we can then close this on. |
|
I have created the PR. |
Author
|
Closing in favor of #473 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #461.