Repository navigation
llama.cpp b11534, executed-test floor, loader output to stderr, JBang example (PR A) - #496
Merged
Merged
Conversation
All eleven patches apply unchanged (verified in order against the pristine tag); see docs/history/llama-cpp-breaking-changes.md for the range. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
Upstream #30210 ("chat : refactor API") moves the chat prompt and parser
state into a common_chat_session: oaicompat_chat_params_parse() takes the
session as its last argument, task_params carries chat_format +
reasoning_format instead of chat_parser_params, server_task::create_state()
is gone and server_response_reader::post_tasks() builds the result state
from the session. jllama.cpp threads a session through the chat entry
points (applyTemplate, handleChatCompletions, requestChatCompletion,
requestChatCompletionStream) and applies it to the task before posting;
the C++ tests follow the new signatures (603 tests, unchanged count).
All eleven patches apply unchanged (verified in order against the pristine
tag); see docs/history/llama-cpp-breaking-changes.md for the range.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
All eleven patches apply unchanged (verified in order against the pristine tag); see docs/history/llama-cpp-breaking-changes.md for the range. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
A router worker JVM (NativeServer.setWorkerCommand) printed "[jllama] using native backend ..." onto the router's command pipe, which the router reports as unexpected output since llama.cpp b11401; the stdout of a java -jar server is otherwise upstream's. The CI smokes read both streams already. Closes the TODO entry. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
verify-test-counts.sh gains --min-executed (run minus skipped), the shape the run count cannot see: method-level assumptions skipping in bulk. Measured on a green run at b11529, the jobs execute 1856 (Windows) to 1865 (Linux) tests, a checkout without the models 1589. Both workflows pass --min-executed 1800 instead of --min-total 1500; closes the TODO entry. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
examples/jbang/Chat.java runs with `jbang <url> model.gguf` and no project. Its //DEPS lines name the classes jar and the CPU natives jar of every desktop platform themselves: JBang treats a pom dependency such as llama-platform as a BOM and puts nothing of it on the classpath (measured). check-natives.py holds the lines to the platform=yes rows of natives.csv and the version to the README's install snippet, with a unit test. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
…iew row Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
What the branch contains, what the sandbox could not verify (models, Windows, GPU), the deliverables in order, and the branch protocol. Deleted again once PR A is merged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
bernardladenthin
had a problem deploying
to
maven-central
October 9, 2026 19:31 — with
GitHub Actions
Failure
bernardladenthin
had a problem deploying
to
maven-central
October 9, 2026 19:31 — with
GitHub Actions
Failure
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
common_chat_sessionthatoaicompat_chat_params_parsefills and the server task applies;jllama.cppthreads a session through its four chat entry points and the C++ tests follow the new signatures (603 tests, unchanged count). None of the removed request fields was aRequestField, so the Java wire surface is unchanged. All eleven patches apply unchanged on every tag; every drop-check still finds its defect. Also in the range: OpenCL kernels that compile on Adreno A6x (#30176), exact GELU for ModernBERT (#30108), no redundant CUDA copies afterSSM_SCAN(#29807). Per-step record indocs/history/llama-cpp-breaking-changes.md.verify-test-counts.shgains--min-executed(run minus skipped), the shape the run count cannot see (method-level assumptions skipping in bulk). Measured on the last green run: 1869 run everywhere, skipped 4 (Linux) / 11 (macOS ×3) / 13 (Windows Ninja + MSVC), so 1856–1865 executed; a checkout without the models executes 1589. Both workflows pass--min-executed 1800instead of--min-total 1500; the model-less local run goes red as intended. TODO entry closed.LlamaLoaderprints its two diagnostic lines to stderr. A router worker JVM printed[jllama] using native backend '…'onto the router's command pipe (unexpected output on the command pipesince b11401). The three smokes already read both streams, so no script change; TODO entry closed.examples/jbang/Chat.java, a one-file console chat forjbang <url> model.gguf, plus a README section. JBang treats apomdependency as a BOM (measured), so the file names the classes jar and the 7 desktop CPU natives jars itself;check-natives.pyholds those lines to theplatform=yesrows and the version to the README's install snippet (unit-tested), and the version-bump list inCLAUDE.mdnames the file.docs/handover/local-agent-pr-a.md— the prompt for the local agent: what the branch contains, what the sandbox could not verify (models, Windows, GPU), the deliverables in order (Windows suite with models, Windows test counts and one red run, router log, JBang against the local snapshot, the B2 pre-verification for the Windows CPU variants) and the branch protocol. To be deleted once this PR is merged.Test plan
git applyin order on pristine b11532 and b11534 (eleven of eleven), fresh configure throughFetchContentat b11531 and b11534;check-patches.py: 11 patches, 98 hunks, 0 problemsctestat b11531 and at b11534: 603/603 passed (Linux x86-64)mvn -f llama/pom.xml test: 1869 run, 0 failures, 280 skipped (model-gated tests self-skip in the sandbox);verify-test-counts.sh --min-executed 1800correctly rejects that run (1589 executed) and accepts synthetic reports with the floor metspotless:check,compile spotbugs:check,javadoc:jargreencheck-natives.py(0 disagreements),check-release-gate.py,check-run-scripts.py,check-shared-files.py(0 changed here alone), buildcheck unit tests (113),reuse lintcompliantexamples/jbang/Chat.javacompiles against the module classes withjavac --release 8; JBang'sgroup:artifact:version:classifierform verified to resolve a classifier jartest counts verifiedline is the first real reading of the executed floor on all six platformsRelated issues / PRs
Checklist
CONTRIBUTING.mdandCODE_OF_CONDUCT.mdSECURITY.md)🤖 Generated with Claude Code
https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
Generated by Claude Code