Skip to content

fix(toolbar): show shared feedback across routes - #17

Merged
bentbrain merged 2 commits into
mainfrom
t3/fix-nested-route-feedback-selection
Oct 14, 2026
Merged

bentbrain merged 2 commits into
mainfrom
t3/fix-nested-route-feedback-selection

Conversation

@bentbrain

Copy link
Copy Markdown
Owner

Show feedback on shared elements across routes of the same website when its selector resolves to a unique, visible anchor. Fetch website-scoped threads before pagination, retain page-local feedback, update shared matches when the DOM changes, and allow shared pins to open their conversations.

Add redacted structural selection for private owner interfaces. data-feedback-redact withholds text and accessible labels while permitting precise element selection and pins. Keeping the existing private marker alongside it preserves protection for older embeds; nested private-only elements remain blocked. Clear the previous outline when hovering a blocked element so a body highlight does not linger.

The companion Japan app change enables owner email-link sign-in and opts the owner region into redacted selection without changing sole-owner access.

@bentbrain

Copy link
Copy Markdown
Owner Author

Independent review completed with no blocking findings for this exact head and base.

  • Reviewer: separate T3 agent, gpt-6.1-sol, high reasoning effort.
  • Task ID: node:delegated-task:command%3Amcp%3A21495b3c-a9ee-4f9a-a3bb-493cecfc0620%3Adelegate-task%3Aowner-email-toolbar-review-r2-ec5eef9-d1e6686.
  • Reviewed head: d1e66866d74bda70512edff2982fe3782035dd4c.
  • Reviewed main base: 87071740cd2a82ffd654f26fcb8a04e4bee44cfe.

Origin-scoped pagination, shared-anchor resolution, host protocol lifecycle, inherited redaction, ancestor-text exclusion, nested private blocks and pin access have no blocking findings.

This review does not replace CI. Any head or base change invalidates this attestation.

- written by a robot 🤖 on behalf of liam 🥸

@bentbrain

Copy link
Copy Markdown
Owner Author

Independent review completed with no actionable findings for the complete diff at this exact head and base.

  • Reviewer: separate T3 agent, gpt-6.1-sol, high reasoning effort.
  • Task ID: node:delegated-task:command%3Amcp%3A21495b3c-a9ee-4f9a-a3bb-493cecfc0620%3Adelegate-task%3Atoolbar-review-r3-810a0a1.
  • Reviewed head: 810a0a1ba7e55989e1d4e1e9f2ce9ded16f4f12f.
  • Reviewed main base: 87071740cd2a82ffd654f26fcb8a04e4bee44cfe.

The review covered refresh startup and navigation, origin containment, shared anchors, observer lifecycle, inherited redaction, nested private regions, protocol limits and pagination. No privacy or security regressions or unresolved objections were found.

This replaces the earlier attestation for the previous head. Any head or base change invalidates this review. CI remains a separate gate.

- written by a robot 🤖 on behalf of liam 🥸

@bentbrain
bentbrain merged commit 26d0c2d into main Oct 14, 2026
14 checks passed
@bentbrain
bentbrain deleted the t3/fix-nested-route-feedback-selection branch October 14, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant