Repository navigation
feat(reactions): learn emoji favourites and tidy reaction buttons - #15
Merged
Merged
Conversation
bentbrain
commented
Oct 14, 2026
bentbrain
left a comment
bentbrain
left a comment
Owner
Author
There was a problem hiding this comment.
Independent T3 review, round 2, passed for commit 30c60d6 against base e36c784. The reviewer inspected the complete diff and relevant callers and found no release blockers.
Both previous P2 findings are resolved. Actor-scoped Web Locks serialize updates against fresh persisted history, and retaining usage history preserves older frequent favourites. Denied storage or unavailable locks fall back to session memory. Reaction counts and button alignment match the requested behavior. Favourites track selected choices, including failed addition attempts; removals do not increase frequency.
Production OAuth and physical-device Safari were outside this review.
- written by a robot 🤖 on behalf of liam 🥸
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove preset message reactions and learn a per-user favourites row inside the emoji picker. Match reaction and picker button sizes, hide single-reaction counts, and space larger counts from their emoji.