Skip to content

Refactor Klatt implementation itself #19

Open

Description

@benjaminwp18

The Klatt implementation is janky. There are some TODOs. Figure out ways to improve.

Activity

  1. benjaminwp18 commented on Oct 27, 2024

    @benjaminwp18
    OwnerAuthor
    1. Store Klatt params better inside the synthesizer object. mast.params["paramname"] is janky.
    2. JS doesn't do keyword args, so the Pythonic massive constructor for params doesn't work. Replace it with passing in an object or daisy chain methods (KlattParam().DUR(1.0).F0(200)).
    3. Use an array instead of individual params for A1 through A6.
    4. Split klatt.js into multiple files.
  2. self-assigned this
    on Nov 6, 2024
  3. linked a pull request that will close this issueKlatt refactor #37on Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions