Do not remove everything that follows a dot in item destination path #5774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue in the path legalization function where the filename’s parts following the dot were being removed. The changes update the tests, modify truncate_path to manually append the suffix, and update the changelog for issue #5771.
- Updated tests in test_util.py to clearly define scenarios with pytest.param.
- Modified truncate_path in beets/util/init.py to concatenate the suffix after truncation.
- Revised changelog documentation to reflect the fix.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/test_util.py | Updated test parameters using pytest.param and removed duplicate variable. |
| docs/changelog.rst | Documented the fix for the path suffix bug in the changelog. |
| beets/util/init.py | Revised truncate_path to manually concatenate the suffix, preserving filename dots. |
snejus
changed the title
Contributor
|
Tested on a previous import and worked as expected. 👏 |
snejus
force-pushed
the
5771-beets-23-doesnt-like-dots-in-the-filename-patterns
branch
from
3eabe35 to
f6e6d5e
Compare
|
This PR fixes the issue for me! |
wisp3rwind
approved these changes
May 12, 2025
semohr
approved these changes
May 12, 2025
TIL that `with_suffix` does not simply append the suffix to the filename - it instead replaces the old/current suffix. Or whatever seems to look like a suffix, in our case, unfortunately...
Also tighten `filetype` attribute type - empty value was previously handled to accommodate a couple of tests, but they aren't failing anymore, it seems.
snejus
force-pushed
the
5771-beets-23-doesnt-like-dots-in-the-filename-patterns
branch
from
f6e6d5e to
a4dabb6
Compare
snejus
deleted the
5771-beets-23-doesnt-like-dots-in-the-filename-patterns
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where path legalization, specifically the
truncate_pathfunction, incorrectly removed parts of filenames that followed a dot. This occurred becausepathlib.Path.with_suffixwas used, which replaces the existing suffix (or what it considers a suffix) rather than just appending.The fix modifies
truncate_pathto manually append the original suffix after truncating the filename stem. This ensures that dots within the filename, not part of the actual extension, are preserved.Fixes #5771.
docs/to describe it.)docs/changelog.rstto the bottom of one of the lists near the top of the document.)