Fix falso positive lyric pages for Tekstowo #3905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
sampsyo
reviewed
Apr 11, 2021
beetsplug/lyrics.py
Outdated
| find("div", class_="card"). \ | ||
| find_all("div", class_="box-przeboje") | ||
|
|
||
| if len(song_rows) < 1: |
Member
There was a problem hiding this comment.
if not song_rows should be equivalent.
beetsplug/lyrics.py
Outdated
|
|
||
| def fetch(self, artist, title): | ||
| url = self.build_url(title, artist) | ||
| print(url) |
Member
There was a problem hiding this comment.
Looks like stray debugging lines.
beetsplug/lyrics.py
Outdated
Comment on lines
426
to
428
| print('--------------------') | ||
| print(song_page_url) | ||
|
|
Member
|
Looks good to me! I'll merge this now, but happy to hear from @njelich if they get a chance to try it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3904
Did mange to reproduce the specific error the user saw
To Do
docs/changelog.rstnear the top of the document.)