which eslint-config?

[bebbi]

eslint-config-react-app

The situation is, it's still a dependency in msm-nodes, and also it's a dep in bebbi-scripts. But I believe it's not used in bebbi-scripts.

Confirm that eslint-config-kentcdodds doesn't depend on react-app config.
We had a discussion over here where I put in my vote for making react-app config the default config. After this, you've added the package to bebbi-scripts in e178220 but looking at it I believe you haven't made it the default in bebbi-scripts.

What is your idea/proposal there? Possible to go with a flexible set up with react-app as the default?

[amaster507]

do you want to bring babel in as a dependency? If we use eslint-config-react-app then that brings with it @babel/core, @babel/eslint-parser, and babel-preset-react-app and a few other things. Using eslint-config-kentcdodds is almost the same without the babel. Is it the rules that you prefer from eslint-config-react-app or some other aspect that you prefer with it? If it is just the name, we might be able to include parts of both of them directly?

[bebbi]

I see, let's go with the quicker/lighter approach then:

• remove eslint-config-react-app
• ok to add the "import/no-extraneous-dependencies" as 2?
• I like to support react's "import/no-anonymous-default-export" rule but when you have storybook it's a bit involved:

"rules": {
      "import/no-anonymous-default-export": 2
    },
    "overrides": [
      {
        "files": [
          "src/**/*.stories.{js,jsx,ts,tsx}"
        ],
        "rules": {
          "import/no-anonymous-default-export": "off"
        }
      }
    ]

Your opinion?

[amaster507]

I take back my previous statement about babel... and then I confused myself more because I was running the wrong commands using npm instead of yarn and got really confused. So it turns out that both use babel, just the one is a direct dependency and the other is a dependency later in the tree. So I switched over to eslint-config-react-app

[bebbi]

👍 Let's close this as part of the corresponding PR.