Temporarily remove pre commit config.#153
Merged
myeatman-bdai merged 1 commit intomasterfrom Jan 22, 2025
Merged
Conversation
petercorke
approved these changes
Jan 18, 2025
Collaborator
petercorke
left a comment
petercorke
left a comment
There was a problem hiding this comment.
I think this is an expedient solution, but we need to get our heads together on a longer-term solution.
Collaborator
|
Removing the file is not enough! For those who actually did the pre-commit install you still need to uninstall but this has to be done before the The install is an action outside of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pre commit check was added a couple of months ago which conflicts with some of the linting and style changes of the repo. This has caused some friction and blocked people from contributing ( see #149).
This PR removes the pre-commit check, with the intention of adding similar functionality back in later, along with PR that ensures the repo conforms with the rules in the pre commit check.