fix: Windows file:\/\// -> file:[\/]+#45
Closed
laggingreflex wants to merge 1 commit intobcoe:masterfrom
Closed
Conversation
On Windows there seems to be `file:///` i.e. 3 forward slashes, whereas here it was only accounting for 2, resul
Contributor
|
This is more complicated than this, the path <-> URL conversion escapes some characters. For Windows, there are also server paths (UNC paths) and long paths ( I wrote a utility library to convert between File URIs and system paths (furi) to solve this c8 issue. While writing it, I found some issues in Node support for file urls so I was waiting for it. I still need to add support for UNC paths (and some doc) but it should already be usable to fix this issue. |
4 tasks
Contributor
Author
|
#46 fixes it better. Closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows (edit: it seems this can be a case on other OSes too) there seems to be
file:///i.e. 3 forward slashes, whereas here it was only accounting for 2, leaving in an extra/Fixes #41
Checklist
npm test, tests passingWeren't passing for me before this fix either.
npm run test:snap(to update the snapshot)tests and/or benchmarks are included~~ documentation is changed or added~~