Skip to content

Feature/kbdev 1306 fix disease matching with subgraphs#73

Merged
mathieulemieux merged 4 commits intodevelopfrom
feature/KBDEV-1306-fix-disease-matching-with-subgraphs
Oct 7, 2025
Merged

Feature/kbdev 1306 fix disease matching with subgraphs#73
mathieulemieux merged 4 commits intodevelopfrom
feature/KBDEV-1306-fix-disease-matching-with-subgraphs

Conversation

@mathieulemieux
Copy link
Member

Now that the ./subgraphs API route is avail., updating the get_kb_disease_matches() function to use it instead of the problematic get_term_tree() function, the same way we experimented doing with a custom similarToExtended fixed query.

Linked to issue described in KBDEV-1306.

Here are some test results:

disease get_term_tree similarToExtended subgraphs
Breast Invasive Lobular Carcinoma 87 240 240
adenocarcinoma in retrorectal cystic hamartoma 10 56 56
bone cancer 1211 4823 4823
carcinoma 11598 33328 33328
cancer 16536 65034 65034

@mathieulemieux mathieulemieux self-assigned this Sep 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.90%. Comparing base (597cb97) to head (dddc839).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #73      +/-   ##
===========================================
+ Coverage    82.88%   82.90%   +0.02%     
===========================================
  Files           18       18              
  Lines         2419     2434      +15     
===========================================
+ Hits          2005     2018      +13     
- Misses         414      416       +2     
Flag Coverage Δ
unittests 82.90% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elewis2
Copy link
Collaborator

elewis2 commented Sep 10, 2025

Can we get a list of the matches for the top two terms in the table above, for review by CLININFO prior to release?

@mathieulemieux
Copy link
Member Author

@mathieulemieux mathieulemieux merged commit 49985f5 into develop Oct 7, 2025
5 checks passed
@mathieulemieux mathieulemieux mentioned this pull request Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants