Feature/kbdev 1306 fix disease matching with subgraphs#73
Merged
mathieulemieux merged 4 commits intodevelopfrom Oct 7, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #73 +/- ##
===========================================
+ Coverage 82.88% 82.90% +0.02%
===========================================
Files 18 18
Lines 2419 2434 +15
===========================================
+ Hits 2005 2018 +13
- Misses 414 416 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Can we get a list of the matches for the top two terms in the table above, for review by CLININFO prior to release? |
Member
Author
|
@elewis2 , I posted examples here: https://www.bcgsc.ca/jira/browse/KBDEV-1306?focusedId=2083990&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-2083990 |
elewis2
approved these changes
Oct 7, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the ./subgraphs API route is avail., updating the get_kb_disease_matches() function to use it instead of the problematic get_term_tree() function, the same way we experimented doing with a custom similarToExtended fixed query.
Linked to issue described in KBDEV-1306.
Here are some test results: