Skip to content

Add login_demo() for GraphKBConnection#72

Merged
mathieulemieux merged 5 commits intodevelopfrom
feature/KBDEV-1328-pori-demo-graphkb-login
Sep 11, 2025
Merged

Add login_demo() for GraphKBConnection#72
mathieulemieux merged 5 commits intodevelopfrom
feature/KBDEV-1328-pori-demo-graphkb-login

Conversation

@mathieulemieux
Copy link
Member

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 31.25000% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.88%. Comparing base (091eddb) to head (8032dd7).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
pori_python/graphkb/util.py 31.25% 11 Missing ⚠️

❌ Your patch status has failed because the patch coverage (31.25%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #72      +/-   ##
===========================================
- Coverage    83.02%   82.88%   -0.15%     
===========================================
  Files           18       18              
  Lines         2404     2419      +15     
===========================================
+ Hits          1996     2005       +9     
- Misses         408      414       +6     
Flag Coverage Δ
unittests 82.88% <31.25%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bnguyen-bcgsc bnguyen-bcgsc requested a review from sshugsc August 11, 2025 15:29
@nodrogluap
Copy link

Can confirm that this edit works from UCalgary, thanks!

@mathieulemieux mathieulemieux removed the request for review from OwenCoelho14 September 10, 2025 22:35
@mathieulemieux mathieulemieux self-assigned this Sep 11, 2025
@mathieulemieux mathieulemieux merged commit 597cb97 into develop Sep 11, 2025
5 checks passed
@mathieulemieux mathieulemieux mentioned this pull request Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants