Repository navigation
feat: nitro modules 37 upgrade - #9
Open
RainbowPlayer wants to merge 1 commit into
Open
RainbowPlayer wants to merge 1 commit into
RainbowPlayer wants to merge 1 commit into
Conversation
Closed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the native integration from Nitro Modules 0.35 to 0.37.1. The JavaScript date API is unchanged.
Changes
nitrogenandreact-native-nitro-modules(dev + both examples): 0.35.7 → 0.37.1>=0.35.0 <0.36.0→>=0.37.0 <0.38.0RELEASE_NOTES_v4.0.0.mdupdatedValidation
NativeDateis a plain C++ HybridObject, so no source changes are needed.bob build(including the nitrogen step),tscand the full Jest suite pass (923/923 withTZ=UTC).Note: 4 tests in
standards.test.tsfail when run in a non-UTC local timezone (e.g. Europe/Kyiv). They fail the same way onmain, so they are unrelated to this change.Supersedes #7 (Nitro 0.36), since the generated code is identical across 0.35 → 0.37.