Describe the bug
To Reproduce
Steps to reproduce the behavior:
- Go to demo app
- Click on
Load demo
- Click on
Settings ⚙️
- toggle
Scroll Sync on
- Click on the progress bar, somewhere past 10 min.
- See error (app crashes)
Expected behavior
For scroll sync to work, without the app to crash
Additional context
Scroll sync uses scrollIntoView as follows
// get the word element - eg
let el = document.querySelector("[data-start='339.86']")
// passing the `centre` value it should avoid jarring movement of the whole interface and
// just move the text to the centre
el.scrollIntoView({block: "center", inline: "center"})
But VisibilitySensor in the WrapperBlock removes the text from the page and so querySelector("[data-start='339.86']") doesn't return an element anymore.
VisibilitySensor in the WrapperBlock was originally introduced to address #150 but didn't do the trick of fixing that problem.
Solution
Remove VisibilitySensor in WrapperBlock. (in #175 branch)
Describe the bug
To Reproduce
Steps to reproduce the behavior:
Load demoSettings⚙️Scroll SynconExpected behavior
For scroll sync to work, without the app to crash
Additional context
Scroll sync uses
scrollIntoViewas followsBut
VisibilitySensorin theWrapperBlockremoves the text from the page and soquerySelector("[data-start='339.86']")doesn't return an element anymore.VisibilitySensorin theWrapperBlockwas originally introduced to address #150 but didn't do the trick of fixing that problem.Solution
Remove
VisibilitySensorinWrapperBlock. (in #175 branch)