buildozer: add new_if_absent command#1384
Open
amartani wants to merge 4 commits intobazelbuild:mainfrom
Open
Conversation
This change adds a new command 'new_if_absent' to buildozer. The 'new_if_absent' command behaves the same as the 'new' command, but it does not fail if a rule with the same name already exists. Instead, it performs a no-op. This is useful for scripts that want to ensure a rule exists without having to check for its existence first.
AnnaSvalova
requested review from
AnnaSvalova
and removed request for
pmbethe09
Collaborator
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the new_if_absent command to buildozer, which behaves like new but avoids failing if the rule already exists. The implementation is well-structured, refactoring existing code to create a shared createNewRule helper function. The changes are supported by updates to documentation and both shell and Go tests. I have a couple of minor suggestions to improve a comment and enhance test robustness.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Contributor
Author
|
I applied gemini's suggestions and merged current main. ptal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a new command 'new_if_absent' to buildozer.
The 'new_if_absent' command behaves the same as the 'new' command, but it does not fail if a rule with the same name already exists. Instead, it performs a no-op.
This is useful for scripts that want to ensure a rule exists without having to check for its existence first.