Fix transitive deps crashes due to IllegalStateException#29289
Closed
jnowjack-lucidchart wants to merge 1 commit intobazelbuild:masterfrom
Closed
Fix transitive deps crashes due to IllegalStateException#29289jnowjack-lucidchart wants to merge 1 commit intobazelbuild:masterfrom
jnowjack-lucidchart wants to merge 1 commit intobazelbuild:masterfrom
Conversation
github-actions
bot
added
team-Core
fmeum
approved these changes
Apr 14, 2026
justinhorvitz
approved these changes
Apr 14, 2026
Collaborator
|
@bazel-io fork 8.7.0 |
Collaborator
|
@bazel-io fork 9.1.0 |
This was referenced Apr 14, 2026
iancha1992
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Apr 15, 2026
…29289) ### Description This adds a needed `valuesMissing()` guard to fix rare crashes with `IllegalStateException` when evaluating `TransitiveTargetKey` nodes whose transitive closures include rules with aspects. ### Motivation Fixes bazelbuild#29280 ### Build API Changes No ### Checklist - [ ] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). ### Release Notes RELNOTES: None Closes bazelbuild#29289. PiperOrigin-RevId: 900232825 Change-Id: I7ba3c5282e4f56a6ef803495b03419b9322c8be3
2 tasks
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Apr 15, 2026
…29289) ### Description This adds a needed `valuesMissing()` guard to fix rare crashes with `IllegalStateException` when evaluating `TransitiveTargetKey` nodes whose transitive closures include rules with aspects. ### Motivation Fixes bazelbuild#29280 ### Build API Changes No ### Checklist - [ ] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). ### Release Notes RELNOTES: None Closes bazelbuild#29289. PiperOrigin-RevId: 900232825 Change-Id: I7ba3c5282e4f56a6ef803495b03419b9322c8be3
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 15, 2026
) (#29307) ### Description This adds a needed `valuesMissing()` guard to fix rare crashes with `IllegalStateException` when evaluating `TransitiveTargetKey` nodes whose transitive closures include rules with aspects. ### Motivation Fixes #29280 ### Build API Changes No ### Checklist - [ ] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). ### Release Notes RELNOTES: None Closes #29289. PiperOrigin-RevId: 900232825 Change-Id: I7ba3c5282e4f56a6ef803495b03419b9322c8be3 Commit 26ceb58 Co-authored-by: Jacob Nowjack <jnowjack@lucidchart.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 15, 2026
) (#29306) ### Description This adds a needed `valuesMissing()` guard to fix rare crashes with `IllegalStateException` when evaluating `TransitiveTargetKey` nodes whose transitive closures include rules with aspects. ### Motivation Fixes #29280 ### Build API Changes No ### Checklist - [ ] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). ### Release Notes RELNOTES: None Closes #29289. PiperOrigin-RevId: 900232825 Change-Id: I7ba3c5282e4f56a6ef803495b03419b9322c8be3 Commit 26ceb58 Co-authored-by: Jacob Nowjack <jnowjack@lucidchart.com>
jnowjack-lucidchart
added a commit
to lucidsoftware/bazel
that referenced
this pull request
Apr 15, 2026
…29289) ### Description This adds a needed `valuesMissing()` guard to fix rare crashes with `IllegalStateException` when evaluating `TransitiveTargetKey` nodes whose transitive closures include rules with aspects. ### Motivation Fixes bazelbuild#29280 ### Build API Changes No ### Checklist - [ ] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). ### Release Notes RELNOTES: None Closes bazelbuild#29289. PiperOrigin-RevId: 900232825 Change-Id: I7ba3c5282e4f56a6ef803495b03419b9322c8be3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a needed
valuesMissing()guard to fix rare crashes withIllegalStateExceptionwhen evaluatingTransitiveTargetKeynodes whose transitive closures include rules with aspects.Motivation
Fixes #29280
Build API Changes
No
Checklist
Release Notes
RELNOTES: None