Skip to content

chore: disable build_python_zip in bazelrcs#3576

Open
rickeylev wants to merge 17 commits intobazel-contrib:mainfrom
rickeylev:pyzipapp.disable.implicit.zip.output
Open

chore: disable build_python_zip in bazelrcs#3576
rickeylev wants to merge 17 commits intobazel-contrib:mainfrom
rickeylev:pyzipapp.disable.implicit.zip.output

Conversation

@rickeylev
Copy link
Collaborator

This sets --build_python_zip=false in our bazelrc files to better reflect the future
state of the zipapp support and flush out issues.

Work towards #2586

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a widespread configuration change to disable the implicit creation of Python zip archives within the Bazel build system. By setting specific flags in the .bazelrc files, the project is proactively adapting to upcoming changes in zipapp support, which will help identify and resolve any compatibility issues early on.

Highlights

  • Python Zip Creation Disabled: Implicit Python zip creation has been disabled across all relevant Bazel configurations by setting --build_python_zip=false.
  • Configuration Update: Multiple .bazelrc files throughout the repository, including the root and various example/integration test directories, have been updated to reflect this change.
  • Future Compatibility: This change aligns the project with the future state of zipapp support and aims to help flush out potential issues related to this transition.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .bazelrc
    • Added common --build_python_zip=false and common --@rules_python//python/config_settings:build_python_zip=false to disable implicit Python zip creation.
  • examples/build_file_generation/.bazelrc
    • Added common --build_python_zip=false and common --@rules_python//python/config_settings:build_python_zip=false to disable implicit Python zip creation.
  • examples/bzlmod/.bazelrc
    • Added common --build_python_zip=false and common --@rules_python//python/config_settings:build_python_zip=false to disable implicit Python zip creation.
  • examples/multi_python_versions/.bazelrc
    • Added common --build_python_zip=false and common --@rules_python//python/config_settings:build_python_zip=false to disable implicit Python zip creation.
  • examples/pip_parse/.bazelrc
    • Added common --build_python_zip=false and common --@rules_python//python/config_settings:build_python_zip=false to disable implicit Python zip creation.
  • examples/pip_parse_vendored/.bazelrc
    • Added common --build_python_zip=false and common --@rules_python//python/config_settings:build_python_zip=false to disable implicit Python zip creation.
  • examples/pip_repository_annotations/.bazelrc
    • Added common --build_python_zip=false and common --@rules_python//python/config_settings:build_python_zip=false to disable implicit Python zip creation.
  • gazelle/.bazelrc
    • Added common --build_python_zip=false and common --@rules_python//python/config_settings:build_python_zip=false to disable implicit Python zip creation.
  • gazelle/examples/bzlmod_build_file_generation/.bazelrc
    • Added common --build_python_zip=false and common --@rules_python//python/config_settings:build_python_zip=false to disable implicit Python zip creation.
  • tests/integration/compile_pip_requirements/.bazelrc
    • Added common --build_python_zip=false and common --@rules_python//python/config_settings:build_python_zip=false to disable implicit Python zip creation.
  • tests/integration/compile_pip_requirements_test_from_external_repo/.bazelrc
    • Added common --build_python_zip=false and common --@rules_python//python/config_settings:build_python_zip=false to disable implicit Python zip creation.
  • tests/integration/local_toolchains/.bazelrc
    • Added common --build_python_zip=false and common --@rules_python//python/config_settings:build_python_zip=false to disable implicit Python zip creation.
  • tests/integration/pip_parse/.bazelrc
    • Added common --build_python_zip=false and common --@rules_python//python/config_settings:build_python_zip=false to disable implicit Python zip creation.
  • tests/integration/py_cc_toolchain_registered/.bazelrc
    • Added common --build_python_zip=false and common --@rules_python//python/config_settings:build_python_zip=false to disable implicit Python zip creation.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request disables implicit Python zip creation by setting --build_python_zip=false in various .bazelrc files throughout the repository. The changes are consistent and correctly apply the necessary flags to move towards deprecating zipapp support. My review identifies a minor but important inconsistency in the issue number referenced in the code comments, which should be corrected for clarity and future maintenance.

@rickeylev rickeylev requested a review from groodt as a code owner February 9, 2026 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants