fix(core): preserve repeated default project selection - #1273
Merged
Conversation
Signed-off-by: phernandez <paul@basicmachines.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Repeatedly choosing the project that is already the default can leave a workspace with no default project. The API still returns success, but subsequent project discovery and every project-scoped MCP tool fail because no default can be resolved.
A production read-only investigation found repeated successful set-default requests followed by a database state where every project row had
is_default = NULL.What Changed
ProjectRepository.set_as_defaultidempotent when the selected project is already the default.Implementation Details
Truebefore the bulk update.Testing
Automated:
uv run pytest -q tests/repository/test_project_repository.py::test_set_as_default_keeps_existing_default— reproduced the failure before the fix and passes after it.uv run pytest -q tests/repository/test_project_repository.py— 14 passed with SQLite.BASIC_MEMORY_TEST_POSTGRES=1 uv run pytest -q tests/repository/test_project_repository.py::test_set_as_default_keeps_existing_default— passed with PostgreSQL.just fast-check— passed (Ruff formatting/lint and type checking).Manual:
Risks / Follow-ups