test(ci): locate Git Bash from MinGW Git path - #1221
Merged
Conversation
Signed-off-by: phernandez <paul@basicmachines.co>
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shutil.which("git")resolves Git for Windows throughmingw64/binbinandcmdGit executable layoutsProblem
PR #1206 fixed the original direct-
.shexecution failure and the WSLbashcollision, but its final Windows SQLite unit job exposed one more Git-for-Windows layout. The test process resolvedgit.exeasC:\Program Files\Git\mingw64\bin\git.exe, while the Bash launcher lives atC:\Program Files\Git\bin\bash.exe. The locator checked only the directory containinggit.exe, so all 12 shell-helper cases failed before invoking the script.This is a test-harness correction only. The merged issue-label reconciliation and per-issue workflow serialization are unchanged.
Changes
bin,cmd, ormingw64/binGit/mingw64/bin/git.exeexecutable maps back toGit/bin/bash.exeTesting
uv run pytest -p pytest_mock --no-cov -q tests/test_claude_issue_triage.py— 14 passedbash -n scripts/edit-issue-labels.sh— passedgit diff --check— passedjust fast-check— passedEvidence