feat(skills): add Pythonic code guidance - #1095
Merged
Merged
Conversation
Signed-off-by: phernandez <paul@basicmachines.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The recent local/cloud runtime consolidation made Basic Memory more capable, but it also exposed how easily portable Python can accumulate protocol towers, helper chains, misleading ownership names, and duplicated source-of-truth assumptions.
We want a shared review and implementation lens for code that is clear to both human and AI contributors: Pythonic without being clever, explicit about domain authority, and conservative about abstraction.
What Changed
/pythonic-codeskill with write, refactor, and review modesdocs/DOMAIN_MODEL.mdto define projects, notes, entities, observations, relations,NoteContent, identity, ownership, and local versus DB-first authorityAGENTS.mdat the domain model and summarize the new house styleImplementation Details
This is guidance rather than a mechanical style mandate. Correctness, compatibility, and existing repository conventions remain higher priority than applying an idiom.
The domain model keeps Markdown as the canonical product representation while distinguishing durable local file authority from the accepted
NoteContentstate used during DB-first materialization.Testing
uv run python /Users/phernandez/.codex/skills/.system/skill-creator/scripts/quick_validate.py .agents/skills/pythonic-code— passedjust package-check— passedjust agent-harness-check— passedgit diff --cached --check— passed before commitRisks / Follow-ups
No runtime behavior changes.
Follow-up cleanup is tracked in:
These should land incrementally rather than turning this PR into a broad refactor.