fix(ci): keep issue triage focused on triage - #1086
Merged
Merged
Conversation
Signed-off-by: phernandez <paul@basicmachines.co>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2cdadc753e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: phernandez <paul@basicmachines.co>
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The automatic Claude issue-triage workflow is intended to classify, label, and comment on new issues. While processing #1084, Claude instead began implementing the reported fix, then became stranded because the triage runner could neither run the required validation nor push its commit. A second explicit request reproduced the same failure.
The workflow should make its triage-only boundary explicit and enforce it at the tool layer so detailed issue reports do not turn into unpublished implementation work.
What Changed
dontAskmode so unavailable approvals cannot wedge the run.Implementation Details
The workflow keeps its existing read-only repository and issue-write permissions. Prompt guidance establishes the intended behavior, while settings-level deny rules prevent the action's automatically supplied git tools from overriding that boundary. Claude can still inspect repository context with
Read,Grep, andGlobwhen useful for accurate triage.The
scripts/edit-issue-labels.shhelper reads the issue number from the trusted workflow event, validates requested labels against the repository, rejects every operation except--add-label, and calls only GitHub's issue-label endpoint. Claude does not receive directgh issue editaccess.This deliberately does not add an implementation or PR-creation path to issue triage.
Testing
.github/workflows/claude-issue-triage.ymlwith PyYAML and parsed the embeddedsettingsvalue withjson.loads.bash -non the label helper.ghcommand to verify valid label additions, unknown-label filtering, and rejection of unsupported operations.git diff --checksuccessfully.No Python application tests were run because this changes only GitHub Actions configuration.
Risks / Follow-ups
The next newly opened issue will provide the live end-to-end verification of the Claude action behavior. The job retains
issues: writeso it can add labels and post comments, while the tool boundary prevents Claude from directly mutating other issue metadata.Related: #1084