fix(mcp): index recreated projects - #1085
Merged
Merged
Conversation
Signed-off-by: phernandez <paul@basicmachines.co>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c996cbf1cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: phernandez <paul@basicmachines.co>
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Re-adding a project after deleting its database record with retained note files created a fresh project identity but never indexed the retained content. The same MCP session could also retain the deleted project identity in its context cache.
Closes #1084
What changed
Request project indexing immediately after a successful project creation.
Run local indexing synchronously so retained notes are available when creation returns.
Use the durable Cloud background indexing handoff and expose accepted state, backend status, message, job ID, and counts.
Clear active/default project identity and workspace project-index caches after both project creation and deletion.
Add a local end-to-end regression for delete with retained notes, recreate, read, and search.
Add unit coverage for local versus Cloud indexing mode and malformed create responses.
Verification
uv run pytest -q --cov-report=term-missing:skip-covered tests/mcp/test_tool_project_management.py tests/mcp/test_tool_json_output_modes.py test-int/mcp/test_project_management_integration.py test-int/mcp/test_output_format_json_integration.py test-int/mcp/test_recreate_project_indexing_integration.py (81 passed)
just fast-check
just doctor
basic-memory-cloud CloudProjectIndexCommand scheduler tests (3 passed)
Cloud rollout
No Cloud source change is required: the existing Cloud project-index command already requires background mode and waits for the PGQueuer handoff before returning. After this core PR merges, basic-memory-cloud will need its pinned Basic Memory revision bumped to deploy the fix.