fix(mcp): surface cloud project deletion job - #1074
Merged
Merged
Conversation
Signed-off-by: phernandez <paul@basicmachines.co>
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Hosted project deletion is asynchronous, but the typed core response model discarded the cloud backend's
job_idand the MCP tool omitted both deletion status and job identity. Callers could only see that note-file deletion was pending, with no handle for tracing the accepted job.What changed
job_idinProjectStatusResponsedelete_projectresult when suppliedVerification
just fast-checkuv run pytest tests/mcp/test_tool_project_management.py -q— 38 passedjust fast-test— 13 passed, 1 skippedThis complements the full storage-prefix purge in basicmachines-co/basic-memory-cloud#1508.
Addresses #1034.