fix(mcp): prevent phantom memory URL edits - #1073
Merged
Merged
Conversation
Signed-off-by: phernandez <paul@basicmachines.co>
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
edit_note could reinterpret an unresolved memory URL route as a path in the active project. For append and prepend, that fallback could create a phantom note. A cross-project resolver match could also flow into a patch scoped to the wrong project and expose an internal entity ID in the resulting error.
What changed
Verification
Risk
The routing behavior changes only after a memory URL project prefix fails to resolve and the identifier also misses in the selected project. Existing indexed memory URL paths continue through the prior compatibility fallback.
Closes #1066