Skip to content

Support auto_postpone_period_in_days and entropy endpoints - #99

Merged
robzolkos merged 2 commits into
masterfrom
rz/auto-postpone-period-in-days
Mar 13, 2026
Merged

Support auto_postpone_period_in_days and entropy endpoints#99
robzolkos merged 2 commits into
masterfrom
rz/auto-postpone-period-in-days

Conversation

@robzolkos

@robzolkos robzolkos commented Mar 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Bump fizzy-sdk to v0.1.2 for auto_postpone_periodauto_postpone_period_in_days rename
  • Rename --auto_postpone_period flag to --auto_postpone_period_in_days on board create and board update
  • Add account show command (GET /account/settings.json)
  • Add account entropy command (PUT /account/entropy.json) for account-level default auto-postpone period
  • Add board entropy command (PUT /boards/:id/entropy.json) for per-board auto-postpone period
  • Validate allowed period values client-side: 3, 7, 11, 30, 90, 365 days

Summary by cubic

Adds account and board entropy commands to manage auto-postpone periods, switches CLI and requests to auto_postpone_period_in_days, and adds account show. Also bumps github.com/basecamp/fizzy-sdk/go to v0.1.2 and improves validation/error messages.

  • New Features

    • account show to view account settings (GET /account/settings.json).
    • account entropy --auto_postpone_period_in_days N to set the account default (PUT /account/entropy.json).
    • board entropy BOARD_ID --auto_postpone_period_in_days N to set per-board values (PUT /boards/:id/entropy.json).
    • Client-side validation with allowed days: 3, 7, 11, 30, 90, 365; clearer errors for missing vs invalid (including negatives).
  • Migration

    • Replace --auto_postpone_period with --auto_postpone_period_in_days in board create and board update. Invalid values are rejected client-side.

Written for commit 44258b0. Summary will update on new commits.

Bump fizzy-sdk to v0.1.2 which renames auto_postpone_period to
auto_postpone_period_in_days and adds typed responses to entropy
endpoints.

- Rename --auto_postpone_period flag to --auto_postpone_period_in_days
  on board create and board update
- Add board entropy command (PUT /boards/:id/entropy.json) to update
  a board's auto-postpone period
- Add account show command (GET /account/settings.json) to view
  account settings including auto-postpone period
- Add account entropy command (PUT /account/entropy.json) to update
  the account-level default auto-postpone period
- Validate allowed values client-side (3, 7, 11, 30, 90, 365 days)
@robzolkos
robzolkos requested a review from a team as a code owner March 11, 2026 01:27
Copilot AI review requested due to automatic review settings March 11, 2026 01:27
@github-actions

github-actions Bot commented Mar 11, 2026

Copy link
Copy Markdown

⚠️ Potential breaking changes detected:

  • Renaming of the flag --auto_postpone_period to --auto_postpone_period_in_days for the board create command.
  • Renaming of the flag --auto_postpone_period to --auto_postpone_period_in_days for the board update command.

Review carefully before merging. Consider a major version bump.

@github-actions github-actions Bot added the enhancement New feature or request label Mar 11, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 10 files

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Fizzy CLI to match the SDK/API rename to auto_postpone_period_in_days, and adds new account/board “entropy” commands for updating default/per-board auto-postpone periods.

Changes:

  • Bumps github.com/basecamp/fizzy-sdk/go to v0.1.2 and renames board create/update flag + payload field to auto_postpone_period_in_days.
  • Adds account show, account entropy, and board entropy commands, plus client-side validation for allowed period values.
  • Updates docs, surface snapshot, and unit/e2e tests to cover the new commands and renamed flag.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
skills/fizzy/SKILL.md Documents new account commands, board entropy, and the renamed flag/field.
internal/skills/SKILL.md Internal copy of the skill docs updated to match new commands/flags.
internal/commands/board.go Renames board auto-postpone flag/field, adds allowed-value validation, introduces board entropy.
internal/commands/board_test.go Updates create tests for renamed field and adds validation + board entropy coverage.
internal/commands/account.go Introduces account show and account entropy commands.
internal/commands/account_test.go Adds tests for account show and account entropy behaviors.
e2e/tests/board_test.go Updates e2e coverage to use --auto_postpone_period_in_days.
go.mod Bumps fizzy-sdk dependency to v0.1.2.
go.sum Updates module sums for the fizzy-sdk bump.
SURFACE.txt Updates CLI surface snapshot for new commands/flags and renamed board flags.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/commands/board.go Outdated
Comment thread internal/commands/board.go
Comment thread internal/commands/account.go Outdated
Comment thread skills/fizzy/SKILL.md
Comment thread internal/skills/SKILL.md
Comment thread internal/commands/board.go Outdated
Comment thread internal/commands/board.go Outdated
Comment thread skills/fizzy/SKILL.md
Comment thread internal/skills/SKILL.md
- Change <= 0 to == 0 for entropy "missing flag" checks so negative
  values get a proper validation error instead of "required flag" error
- Change > 0 to != 0 for board create/update so negative values are
  rejected by validation instead of silently ignored
- Generate allowed-values help string from validAutoPostponePeriods
  slice to avoid drift between the slice, error message, and flag help
- Document allowed values (3, 7, 11, 30, 90, 365) in SKILL.md for
  both account entropy and board entropy commands
@robzolkos
robzolkos requested a review from jeremy March 11, 2026 01:57
robzolkos added a commit that referenced this pull request Mar 11, 2026
Adds CLI commands for every SDK method not yet exposed:

- board: closed, postponed, stream (board card views), involvement
- card: publish, mark-read, mark-unread
- column: move-left, move-right
- step: list
- user: role, avatar-remove, push-subscription-create, push-subscription-delete
- account: show, settings-update, export-create, export-show,
  join-code-show, join-code-reset, join-code-update
- notification: settings-show, settings-update

Excludes UpdateEntropy (account + board) which is covered by PR #99.
@robzolkos
robzolkos merged commit 9404695 into master Mar 13, 2026
19 checks passed
@robzolkos
robzolkos deleted the rz/auto-postpone-period-in-days branch March 13, 2026 00:03
robzolkos added a commit that referenced this pull request Mar 13, 2026
Adds CLI commands for every SDK method not yet exposed:

- board: closed, postponed, stream (board card views), involvement
- card: publish, mark-read, mark-unread
- column: move-left, move-right
- step: list
- user: role, avatar-remove, push-subscription-create, push-subscription-delete
- account: show, settings-update, export-create, export-show,
  join-code-show, join-code-reset, join-code-update
- notification: settings-show, settings-update

Excludes UpdateEntropy (account + board) which is covered by PR #99.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants