Repository navigation
chore: sync VPS native VERSION and README to Svelte 5.56.8 - #1831
Closed
baseballyama wants to merge 1 commit into
Closed
baseballyama wants to merge 1 commit into
baseballyama wants to merge 1 commit into
Conversation
The 5.56.8 submodule bump (377ec35, #1785) left two drift checks red: - `check-vps-version.mjs` compares the hardcoded VERSION export in apps/npm/vite-plugin-svelte-native/index.cjs against submodules/svelte/packages/svelte/package.json; bump 5.56.7 -> 5.56.8. - `update-docs.mjs --check` (Compatibility Report job) verifies the <!-- svelte-target-version --> marker in README.md matches the submodule's version/short-hash; update to v5.56.8 @ 44a781373057. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014ER8ncJhRQKMdxB1e7a7wH
Contributor
Merging this PR will not alter performance
Comparing Footnotes
|
Owner
Author
|
Superseded by #1826, which landed the same README/VERSION sync (plus AGENTS.md and a changeset) on main first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Svelte submodule bump to 5.56.8 (377ec35, #1785) left main's CI red on two independent drift checks:
VPS native VERSION drift check (
node scripts/dev/check-vps-version.mjs) —apps/npm/vite-plugin-svelte-native/index.cjshardcodes amodule.exports.VERSIONstring literal (no build step regenerates it) that must matchsubmodules/svelte/packages/svelte/package.json'sversionfield. It was still'5.56.7'. Bumped to'5.56.8'.Compatibility Report job → "Check README is in sync with Svelte submodule" (
node scripts/dev/update-docs.mjs --check) — this only touches/verifies the<!-- svelte-target-version -->…<!-- /svelte-target-version -->marker block inREADME.md, comparing it againstsubmodules/svelte/packages/svelte/package.json's version andgit rev-parse HEAD(short hash) of the submodule. The compatibility table itself is maintained separately/manually and is untouched by this check. README still saidv5.56.7@b29d7002ecf9. Updated tov5.56.8@44a781373057, matching the now-pinned submodule commit.Both fixes are minimal, targeted edits — no full compatibility report regeneration was needed since
--checkonly validates the version marker, not the pass/fail table.Test plan
git submodule update --init submodules/svelte→ confirmed pinned at44a7813730579b94004e182e5a67aab27aa9d2a6,package.jsonversion5.56.8node scripts/dev/check-vps-version.mjs→[check-vps-version] VERSION '5.56.8' matches submodules/svelte.node scripts/dev/update-docs.mjs --check(against a locally-generatedfixtures/44a781373057/compatibility-report.jsonstub, not committed — gitignored) →README.md Svelte target marker is in sync (v5.56.8 @ 44a781373057)🤖 Generated with Claude Code