Skip to content
This repository was archived by the owner on Jul 28, 2022. It is now read-only.

Fixing missing check for active catalyst instance on react context #71

Merged
Minishlink merged 1 commit into from
Jan 23, 2022
Merged

Fixing missing check for active catalyst instance on react context #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions android/src/main/java/tech/bam/RNBatchPush/RNBatchModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import android.content.res.Resources;
import android.graphics.Typeface;
import android.location.Location;
import android.util.Log;

import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
Expand Down Expand Up @@ -141,6 +142,11 @@ public void optOutAndWipeData(Promise promise) {
private void sendEvent(ReactContext reactContext,
String eventName,
@Nullable WritableMap params) {

if (!reactContext.hasActiveCatalystInstance()) {
Log.d(NAME, "React context has no active catalyst instance. Aborting send event.");

@Minishlink Minishlink Jan 23, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we would store the event, and send it later once react gets an active catalyst instance
Otherwise you lose the event :/

return;
}
reactContext
.getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class)
.emit(eventName, params);

@Minishlink Minishlink Jan 23, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it crash here? If so there might be a bug in RN and we should open an issue on their repo

Expand Down