Conversation
gitopscli/commands/sync_apps.py
Outdated
|
|
||
|
|
||
| def __clean_yaml(values: Dict[str, Any]) -> Any: | ||
| # storing yaml to allow deletion while iterating |
There was a problem hiding this comment.
can you get rid of the comments? If you think you need them, I would extract them to subfunctions and name these accordingly
gitopscli/commands/sync_apps.py
Outdated
| from gitopscli.gitops_exception import GitOpsException | ||
| from .command import Command | ||
|
|
||
| # array of allowed values for __clean_yaml function |
There was a problem hiding this comment.
get rid of comment, you change variable name if the name itself is not descriptive enough
christiansiegel
left a comment
christiansiegel
left a comment
There was a problem hiding this comment.
Thanks for the PR :) But could you please elaborate on what you are trying to achieve? Maybe describe your new feature in the documentation (docs folder)
| for key in values.keys(): | ||
| logging.info("processing %s ", key) | ||
| # checking if key is in blacklist and remove it if necessary | ||
| if key in YAML_BLACKLIST: |
There was a problem hiding this comment.
This list is always empty
There was a problem hiding this comment.
The list is set in case of keywords that would need to be removed. by default it's empty and allow all keywords.
| "applications": {"some-other-app-2": None}, | ||
| }, | ||
| "/tmp/team-config-repo/my-app/values.yaml": { | ||
| "config": {"repository": "https://team.config.repo.git", "applications": {"some-other-app-1": None}} |
There was a problem hiding this comment.
Why is there a app/team config yaml in a app/team config repo? We are using app/team config yamls in the root config repo to find app/team config repos: https://baloise.github.io/gitopscli/commands/sync-apps/#root-config-repository
There was a problem hiding this comment.
this implementation answer COP-1705 to have app specific configuration.
|
As asked , trivial comments had been removed to improve code comprehension |
4 participants
added function to filter app specific yaml files entries.