Update backbutton.php, backbutton.xml and en-GB files#3
Open
ActiveScottShaw wants to merge 3 commits intobackbutton:masterfrom
Open
Update backbutton.php, backbutton.xml and en-GB files#3ActiveScottShaw wants to merge 3 commits intobackbutton:masterfrom
ActiveScottShaw wants to merge 3 commits intobackbutton:masterfrom
Conversation
Re-written code to use the joomla api rather than $SERVER variables
Added in an extra parameter setting, so users can choose which link structure they require
Added in the language values for the new parameter
wojsmol
added a commit
that referenced
this pull request
Oct 12, 2015
Author
|
Hi, many thanks for having a look at the code ... I see you have made a couple of tweaks ... which is cool! I have downloaded your changes to have a look, and have re-uploaded them to our test site .... and it does not seem to work now? .... if we remove the ',1' which was added to the get param statement ... then it works again. Seems that having the ',1' is always making it think it is set to that parameter? ... not sure ... any ideas? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
I have implemented all of your suggestions (I think), I have looked through the link you pointed me to, and have gone through joomla rather than using $SERVER, I have sanitized the 'Referer URL' (I think I have done that correctly), added in a new plugin parameter which is set to 'Yes' by default, which means it will be using your link structure by default. And have added in the label and description to the en-GB language file.
Really hope that is all ok.