Repository navigation
refactor(sequencer): align streaming Inbox selection names with their docs - #342
Open
spalladino wants to merge 3 commits into
Open
spalladino wants to merge 3 commits into
spalladino wants to merge 3 commits into
Conversation
alexghr
approved these changes
Oct 2, 2026
…fe local end it holds
…heir prose Rename getOrdinaryCeiling to getEndpointLookupThreshold and selectOrdinaryMessageEnd to selectGreedyEnd, the words the jsdocs, tests and README already use. Drop both, and mustQueryEndpoint, from the package root export; nothing outside sequencer-client imports them. Add InboxSelectionPositions for the three observed counts the selection functions take, a module header for the shared count coordinate, and correct the README's description of the endpoint lookup bound.
…d rename the last ceiling local
spalladino
force-pushed
the
spl/inbox-position-vocabulary
branch
from
October 9, 2026 19:31
834e157 to
f85c23c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the streaming Inbox selection functions so their names use the words their own docs, tests and README already use, and fixes one variable that named the wrong concept. No behaviour change. Stacked on #340.
Context
The selection module called the greedy step "ordinary" and the endpoint-lookup threshold a "ceiling", while every comment, test and README paragraph said "greedy" and "threshold". The node's simulator stored the result of
selectSafeLocalEndin a variable namedgreedyEnd, which is the other function's concept. The three observed counts every selection function takes were declared inline four times with no docs.Approach
getOrdinaryCeiling→getEndpointLookupThreshold,selectOrdinaryMessageEnd→selectGreedyEnd.safeLocalEnd.InboxSelectionPositionstype (cursor, local synced, checkpoint start counts) with a doc per field, used by the selection functions and the consumption class's snapshot. It is structurally identical to the inline types, so no call site changes.bucketSeqis an ordinal, not a count.API changes
getOrdinaryCeiling,selectOrdinaryMessageEndandmustQueryEndpointare removed from the@aztec-labs/sequencer-clientroot export. Nothing outside the package imports them, and they have only shipped in v6 nightlies.