Skip to content

feat(i18n): add English(en-US.json) translations based on zh-CN.json#649

Merged
ayangweb merged 8 commits into
ayangweb:masterfrom
cuonglmptit:i18n
Sep 18, 2025
Merged

feat(i18n): add English(en-US.json) translations based on zh-CN.json#649
ayangweb merged 8 commits into
ayangweb:masterfrom
cuonglmptit:i18n

Conversation

@cuonglmptit

Copy link
Copy Markdown
Contributor

No description provided.

@ayangweb

Copy link
Copy Markdown
Owner

Thank you. Please take a look: #647 (comment)

@cuonglmptit

Copy link
Copy Markdown
Contributor Author

I've just updated the branch for this PR. Please take a look. @ayangweb

Comment thread src/locales/en-US.json Outdated
Comment thread src/locales/en-US.json Outdated
Comment thread src/locales/en-US.json Outdated
@ayangweb

ayangweb commented Sep 18, 2025

Copy link
Copy Markdown
Owner

The colons and Spaces mentioned above should also be added in Vietnamese. Thank you.

@cuonglmptit

Copy link
Copy Markdown
Contributor Author

Updated!

Comment thread src/locales/en-US.json Outdated
Comment thread src/locales/en-US.json
Comment thread src/locales/vi-VN.json
@cuonglmptit

Copy link
Copy Markdown
Contributor Author

I believe this looks good this time.

Comment thread src/locales/en-US.json Outdated
@ayangweb

Copy link
Copy Markdown
Owner

I believe this looks good this time.

Thank you for your contribution. Just make the changes mentioned above, and I’ll proceed with the merge. After that, I’ll make some minor UI adjustments and prepare to release the new version.

@cuonglmptit

Copy link
Copy Markdown
Contributor Author

I just updated that change.

@cuonglmptit

Copy link
Copy Markdown
Contributor Author

Should be all good now. Hard to believe I missed that.

@ayangweb

Copy link
Copy Markdown
Owner

Should be all good now. Hard to believe I missed that.

Thanks, I'm going to merge it.

@ayangweb ayangweb merged commit c163f52 into ayangweb:master Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants