pylsp delete all text when formatting

[nkta3m]

Version confirmation

• Confirm

Following prerequisites

• Confirm

Not a user config issue

• Confirm

Neovim version

NVIM v0.9.4 Build type: Release LuaJIT 2.1.1692716794

Operating system/version

Debian

Terminal name/version

alacritty

$TERM environment variable

No response

Branch info

main (Default/Latest)

Fetch Preferences

HTTPS (use_ssh = false)

Affected language servers

pylsp

How to reproduce the issue

1. open python file
2. save

Actual behavior

normal format

Expected behavior

No response

Support info

Logs

[ERROR][2023-10-18 14:41:56] .../vim/lsp/rpc.lua:734	"rpc"	"~/.local/share/nvim/mason/bin/pylsp"	"stderr"	"2023-10-18 14:41:56,891 CST - ERROR - pylsp_ruff.plugin - Error running ruff: error: unexpected argument '--format' found\n\n  tip: to pass '--format' as a value, use '-- --format'\n\nUsage: ruff check <--verbose|--quiet|--silent> [FILES]...\n\nFor more information, try '--help'.\n\n"

Additional information

No response

[charliie-dev]

seems like an upstream error, have u check their repo yet?

[nkta3m]

no, i don't know how to configure pylsp.

[ayamir]

In fact, ruff is not responsible for formatting, it just provides the code lint function. black is installed to do format. I have no idea about the error log.

[nkta3m]

Is it possible to specify the version of pylsp?

[ayamir]

Is it possible to specify the version of pylsp?

You reminded me. I upgraded the latest pylsp. This bug can be reproduced for pylsp (version==1.8.2)

[ayamir]

python-lsp/python-lsp-ruff#49
python-lsp/python-lsp-ruff#48

[ayamir]

The workaround is to use black via null-ls and disable the format function from pylsp.

@nkta3m Add these lines to lua/user/settings.lua.

settings["server_formatting_block_list"] = {
	pylsp = true,
}
settings["null_ls_deps"] = {
	"black",
}

Additionally, to use the lint function normally before python-lsp-ruff be fixed, you should enable flake8 or pyflakes by adding lua/user/configs/lsp-servers/pylsp.lua with the following content:

-- https://github.com/neovim/nvim-lspconfig/blob/master/lua/lspconfig/server_configurations/pylsp.lua
return {
	cmd = { "pylsp" },
	filetypes = { "python" },
	settings = {
		pylsp = {
			plugins = {
				-- Lint
				ruff = {
					enabled = false,
					select = {
						-- enable pycodestyle
						"E",
						-- enable pyflakes
						"F",
					},
					ignore = {
						-- ignore E501 (line too long)
						-- "E501",
						-- ignore F401 (imported but unused)
						-- "F401",
					},
					extendSelect = { "I" },
					severities = {
						-- Hint, Information, Warning, Error
						F401 = "I",
						E501 = "I",
					},
				},
				flake8 = { enabled = true },
				pyflakes = { enabled = false },
				pycodestyle = { enabled = false },
				mccabe = { enabled = false },

				-- Code refactor
				rope = { enabled = true },

				-- Formatting
				black = { enabled = true },
				pyls_isort = { enabled = false },
				autopep8 = { enabled = false },
				yapf = { enabled = false },
			},
		},
	},
}

[nkta3m]

Great, thanks!