Restore enhanced stacktraces when libbacktrace is not found#192
Open
marcomagdy wants to merge 4 commits intoawslabs:masterfrom
Open
Restore enhanced stacktraces when libbacktrace is not found#192marcomagdy wants to merge 4 commits intoawslabs:masterfrom
marcomagdy wants to merge 4 commits intoawslabs:masterfrom
Conversation
This reverts commit e08ca6e.
This maintains the enhanced stacktraces even if libbacktrace is not found.
Collaborator
|
Trying to test this out - I added a CI workflow with an Alpine 3.19 container - which shows as expected that the Also tried adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores the enhanced stack traces (with line numbers and source filenames) even when libbacktrace is not found.
It also ensures that Alpine would continue to work as expected since the package is now not "required".
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.