tests: add test for DefaultAuthorizers not a string in API - #2313
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2313 +/- ##
===========================================
+ Coverage 93.58% 94.47% +0.89%
===========================================
Files 90 97 +7
Lines 6124 7061 +937
Branches 1260 1435 +175
===========================================
+ Hits 5731 6671 +940
+ Misses 183 177 -6
- Partials 210 213 +3
Continue to review full report at Codecov.
|
hawflau
approved these changes
Feb 7, 2022
mildaniel
approved these changes
Feb 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In issue #1245, we had a cases were SAM would fail due to improper validation.
In updating #1286, I noticed this was patched in #1774 but we only added tests
for AWS::Serverless::StateMachine. This commit adds an additional test to cover
AWS::Serverless::Api.
Issue #, if available:
n/a but is a test to cover #1245
Description of changes:
Adds additional test
Description of how you validated changes:
make prran successfullyChecklist:
make prpassesExamples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam initthrough https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.