fix: Better Error Handling of Intrinsics - #1896
Merged
Merged
Conversation
In HTTP API authorizers, we don't yet handle intrinsics, and an attempt to use them creates a crash when it tries to hash the input `dict`. This change starts by wrapping that use case properly so that a helpful error is raised until intrinsics are supported here. Note: Does not yet handle `!Sub`, looking at options for that.
CoshUS
approved these changes
Jan 21, 2021
Codecov Report
@@ Coverage Diff @@
## develop #1896 +/- ##
===========================================
+ Coverage 93.84% 93.89% +0.05%
===========================================
Files 89 89
Lines 5881 5885 +4
Branches 1203 1205 +2
===========================================
+ Hits 5519 5526 +7
+ Misses 166 164 -2
+ Partials 196 195 -1
Continue to review full report at Codecov.
|
Should not raise, making that explicit.
jfuss
approved these changes
Jan 25, 2021
mgrandis
pushed a commit
to mgrandis/serverless-application-model
that referenced
this pull request
Mar 2, 2021
* Better Error Handling of Intrinsics In HTTP API authorizers, we don't yet handle intrinsics, and an attempt to use them creates a crash when it tries to hash the input `dict`. This change starts by wrapping that use case properly so that a helpful error is raised until intrinsics are supported here. Note: Does not yet handle `!Sub`, looking at options for that. * Add "NoValue" Test Case Should not raise, making that explicit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In HTTP API authorizers, we don't yet handle intrinsics, and an attempt
to use them creates a crash when it tries to hash the input
dict. Thischange starts by wrapping that use case properly so that a helpful error
is raised until intrinsics are supported here.
Note: Does not yet handle
!Sub, looking at options for that.Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.