Conversation
* feat: add support for VPCEndpointIds in EndpointConfiguration * fix: update formatting with black * docs: update 2016-10-31.md * docs: added api endpointconfiguration example * docs: make example more generic * fix: remove nested EndpointConfiguration types from output * fix: only allow one EndpointConfiguration Type * doc: update example to reflect only allowing one EndpointConfiguration Type * fix : missing UserPool properties (#1506) (#1581) * fix: resource policy generation for {path+} (#1580) * refactor: Remove 2016-10-31 examples * update PR template * adjust pr template * Adding authorization scopes as list validation in ApiGatewayAuthorizer (v1 and v2). (#1670) * Adding authorization scopes as list validation in ApiGatewayAuthorizer and ApiGatewayV2Authorizer. * make black. * Adding functional test for invalid auth scope. * adding error condition for invalid test. * removing test template file. * feat: MSK event type support for AWS::Serverless::Function (#52) Co-authored-by: Steve Brown <steve@fabric.com> Co-authored-by: jtaylor00 <joetaylor00@gmail.com> Co-authored-by: Jacob Fuss <jfuss@users.noreply.github.com> Co-authored-by: Alex Wood <awood45@gmail.com> Co-authored-by: Tarun <c2tarun@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## develop #1685 +/- ##
===========================================
- Coverage 94.12% 94.09% -0.03%
===========================================
Files 86 86
Lines 5547 5423 -124
Branches 1167 1084 -83
===========================================
- Hits 5221 5103 -118
- Misses 146 148 +2
+ Partials 180 172 -8
Continue to review full report at Codecov.
|
c2tarun
approved these changes
Aug 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging back from master to develop, to keep develop upto date. Looks like the large number of changes are just deleted examples.
feat: add support for VPCEndpointIds in EndpointConfiguration
fix: update formatting with black
docs: update 2016-10-31.md
docs: added api endpointconfiguration example
docs: make example more generic
fix: remove nested EndpointConfiguration types from output
fix: only allow one EndpointConfiguration Type
doc: update example to reflect only allowing one EndpointConfiguration
Type
fix : missing UserPool properties (Immutable AWS::Cognito::UserPool properties are not supported in the SAM translator. #1506) (fix : missing UserPool properties (#1506) #1581)
fix: resource policy generation for {path+} (fix: resource policy generation for {path+} #1580)
refactor: Remove 2016-10-31 examples
update PR template
adjust pr template
Adding authorization scopes as list validation in ApiGatewayAuthorizer (v1 and v2). (Adding authorization scopes as list validation in ApiGatewayAuthorizer (v1 and v2). #1670)
Adding authorization scopes as list validation in ApiGatewayAuthorizer and ApiGatewayV2Authorizer.
make black.
Adding functional test for invalid auth scope.
adding error condition for invalid test.
removing test template file.
feat: MSK event type support for AWS::Serverless::Function (Code pipline fails: ChangeSetNotFound; Request ID: d0519f50-c952-11e6-90c7-533dc3f576eb) #52)
Co-authored-by: Steve Brown steve@fabric.com
Co-authored-by: jtaylor00 joetaylor00@gmail.com
Co-authored-by: Jacob Fuss jfuss@users.noreply.github.com
Co-authored-by: Alex Wood awood45@gmail.com
Co-authored-by: Tarun c2tarun@users.noreply.github.com
Issue #, if available:
Description of changes:
Description of how you validated changes:
Checklist:
make prpassesExamples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam initthrough https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.