Chore: Add unit and integ tests for already upgraded search functionality in jumpstart code #5544
+106
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Original code used
eval()to evaluate user filter expressions in JumpStart search, allowing arbitrary code execution. This is already fixed and merged in: #5497Description of changes:
Added 19 tests verifying the fix:
__import__,exec,eval, file access, etc.) and AST parser is used instead ofeval()All tests pass, confirming injection attempts return
Falsewithout executing code.Also added unit test fixes for sagemaker-train that is constantly failing for all PRs.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.