Fix a bug that rollback a failed transaction causes server crash.#211
Merged
Fix a bug that rollback a failed transaction causes server crash.#211
Conversation
The root cause of the crash is when the transaction fails, it's set to aborted state; get_extension_oid function needs a relcache lookup which must be done in a transaction state. This change fixes this issue by skipping TransactionStmts in process utility hook.
jkatz
approved these changes
Jul 3, 2023
Comment on lines
+3989
to
+3996
| if (prev_hook) | ||
| { | ||
| _prev_hook; | ||
| } | ||
| else | ||
| { | ||
| _standard_ProcessUtility; | ||
| } |
Contributor
There was a problem hiding this comment.
Nonblocking comment, given it's written otherwise further down on the function, but a future refactor could simplify this to:
Suggested change
| if (prev_hook) | |
| { | |
| _prev_hook; | |
| } | |
| else | |
| { | |
| _standard_ProcessUtility; | |
| } | |
| if (prev_hook) | |
| _prev_hook; | |
| else | |
| _standard_ProcessUtility; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #208
The root cause of the crash is when the transaction fails, it's set to aborted state; get_extension_oid function needs a relcache lookup which must be done in a transaction state.
This change fixes this issue by skipping TransactionStmts in process utility hook.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.