feat(manifest): Add target and cache from build options#1555
Merged
mergify[bot] merged 2 commits intoaws:mainlinefrom Oct 26, 2020
Merged
feat(manifest): Add target and cache from build options#1555mergify[bot] merged 2 commits intoaws:mainlinefrom
mergify[bot] merged 2 commits intoaws:mainlinefrom
Conversation
mRoca
force-pushed
the
feat/build-options
branch
from
08dba73 to
c38908d
Compare
Contributor
efekarakus
reviewed
Oct 23, 2020
Contributor
efekarakus
left a comment
efekarakus
left a comment
There was a problem hiding this comment.
Amazing! Only small text recommendations but otherwise the code looks great 👌
mRoca
force-pushed
the
feat/build-options
branch
from
c38908d to
ae81915
Compare
mRoca
force-pushed
the
feat/build-options
branch
from
ae81915 to
726ee20
Compare
bvtujo
approved these changes
Oct 26, 2020
Contributor
bvtujo
left a comment
bvtujo
left a comment
There was a problem hiding this comment.
This looks awesome, thank you so much for the contribution!
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
This PR allows to specify the `--target` and `--cache-from` docker build options with a [docker-compose](https://docs.docker.com/compose/compose-file/#cache_from) like syntaxe ```yaml image: build: dockerfile: path/to/dockerfile context: context/dir target: build-stage cache_from: - image:tag args: key: value ``` The `cache_from` option allows to pull a previously built image and use it as cache layers, and the `target` option allows... well, to use a multi-stages Dockerfile. Resolves aws#1331 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows to specify the
--targetand--cache-fromdocker build options with a docker-compose like syntaxeThe
cache_fromoption allows to pull a previously built image and use it as cache layers, and thetargetoption allows... well, to use a multi-stages Dockerfile.Resolves #1331
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.