Fixing an issue with path encoding in SigV4 that affects Cognito#633
Merged
jeremeamia merged 2 commits intomasterfrom Jun 16, 2015
Merged
Fixing an issue with path encoding in SigV4 that affects Cognito#633jeremeamia merged 2 commits intomasterfrom
jeremeamia merged 2 commits intomasterfrom
Conversation
Contributor
|
Do the integration tests all pass? After those are added: 🚢 |
Contributor
Author
|
@mtdowling New integ tests added for this. Other tests were passing as well (tried them all before the PR). |
jeremeamia
force-pushed
the
fix/sigv4-path-encoding
branch
from
d2e33bb to
5e0ce2e
Compare
… being encoded correctly when signing requests.
jeremeamia
force-pushed
the
fix/sigv4-path-encoding
branch
from
5e0ce2e to
616b78c
Compare
Contributor
|
The tests look nice, too. |
jeremeamia
added a commit
that referenced
this pull request
Jun 16, 2015
Fixing an issue with path encoding in SigV4 that affects Cognito
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to forum post: https://forums.aws.amazon.com/thread.jspa?threadID=182601
CR PLZ: @mtdowling @jeskew