feat: Add click command for cloud invoke command - #5238
Conversation
Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>
Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>
Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>
Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @configuration_option(provider=TomlProvider(section="parameters")) | ||
| @click.option("--stack-name", required=False, help="Name of the stack to get the resource information from") | ||
| @click.option("--resource-id", required=False, help="Name of the resource that will be invoked") | ||
| @click.option( |
There was a problem hiding this comment.
we need similarly named options to have homogenity between local and cloud invoke?
There was a problem hiding this comment.
Yeah, this is something we will be discussing with the UX team next week. I will raise a follow up PR for the new UX changes to the help text and can add any named option changes there.
| return resource_summary | ||
|
|
||
| @property | ||
| def stdout(self) -> StreamWriter: |
There was a problem hiding this comment.
Should this be more common than here?
There was a problem hiding this comment.
I added it to the context because if we decide to add another handle, for instance log_file option that sam local has, we can add that here directly after passing it to the context.
mndeveci
left a comment
mndeveci
left a comment
There was a problem hiding this comment.
Thanks for addressing all the feedback. Left a comment about a class naming, I think we need to rename all modules & classes once we decide the command naming.
| return {key: _value} | ||
|
|
||
|
|
||
| class RemoteInvokeBotoApiParameterType(click.ParamType): |
There was a problem hiding this comment.
Sorry that I didn't see this one before, but we may just hold on to remote invoke and change it afterwards if we decide to move forward with cloud invoke name.
There was a problem hiding this comment.
Yup that's right, left it as remote invoke here to keep it consistent with other places that use remote invoke. We can refactor all modules/classes/variable names once we confirm the name to be used.
4 participants
Which issue(s) does this change fix?
#5018
This PR adds the click command for the new feature called
cloud invoke. The formatting of the UX will be done in a separate PR.What side effects does this change have?
N/A
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.