Skip to content

fix: sam validate with local image - #2892

Merged
hoffa merged 6 commits into
aws:developfrom
hoffa:fix-sam-validate
Aug 24, 2021
Merged

fix: sam validate with local image#2892
hoffa merged 6 commits into
aws:developfrom
hoffa:fix-sam-validate

Conversation

@hoffa

@hoffa hoffa commented May 20, 2021

Copy link
Copy Markdown
Contributor

Which issue(s) does this change fix?

#2893
#2613

Why is this change necessary?

How does it address the issue?

Create fake ImageUri when the image is referenced locally.

What side effects does this change have?

Tested with:

SAM_CLI_TELEMETRY=0 make func-test

Checklist

  • Add input/output type hints to new functions/methods
  • Write design document (Do I need to write a design document?)
  • Write unit tests
  • Write/update functional tests
  • Write/update integration tests
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hoffa
hoffa marked this pull request as ready for review May 21, 2021 04:51
Comment thread samcli/commands/validate/lib/sam_template_validator.py Outdated

@aahung aahung left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread samcli/commands/validate/lib/sam_template_validator.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants