Skip to content

fix: Go 1.16 set GOFLAGS to allow change of go.mod and go.sum - #2646

Merged
sriram-mv merged 1 commit into
aws:developfrom
sriram-mv:fix_go_tests
Feb 22, 2021
Merged

fix: Go 1.16 set GOFLAGS to allow change of go.mod and go.sum#2646
sriram-mv merged 1 commit into
aws:developfrom
sriram-mv:fix_go_tests

Conversation

@sriram-mv

@sriram-mv sriram-mv commented Feb 22, 2021

Copy link
Copy Markdown
Contributor

Which issue(s) does this change fix?

  • Go integration tests

Why is this change necessary?

  • Go 1.16 introduced a breaking change with go build no longer being allowed to change/create go.mod and go.sum files by default.
  • Initial Assessment was that setting go env will not fix this, but that been set incorrectly without an "=" sign.

How does it address the issue?

  • Set a go env variable to allow for changes.

What side effects does this change have?

  • None, allows for build tests to start passing again.

Checklist

  • Add input/output type hints to new functions/methods
  • Write design document (Do I need to write a design document?)
  • Write unit tests
  • Write/update functional tests
  • Write/update integration tests
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aahung aahung left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. We also need to do the same for Canary

@sriram-mv

Copy link
Copy Markdown
Contributor Author

@aahung : https://github.com/aws/aws-sam-cli/blob/develop/appveyor.yml#L91 (There looks to be a version lock for go)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants