fix: Go 1.16 set GOFLAGS to allow change of go.mod and go.sum - #2646
Merged
Conversation
sriram-mv
force-pushed
the
fix_go_tests
branch
from
February 22, 2021 04:44
ecd8169 to
dd3ba41
Compare
aahung
suggested changes
Feb 22, 2021
aahung
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing. We also need to do the same for Canary
CoshUS
approved these changes
Feb 22, 2021
Contributor
Author
|
@aahung : https://github.com/aws/aws-sam-cli/blob/develop/appveyor.yml#L91 (There looks to be a version lock for go) |
aahung
approved these changes
Feb 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Why is this change necessary?
How does it address the issue?
What side effects does this change have?
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.